Get /models passing mypy checks.
#15062
Conversation
bunchesofdonald
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
bunchesofdonald
force-pushed
the
mypy-models
branch
from
3c6c1b4
to
28046dc
Compare
| async def read_configuration_value(self, session: sa.orm.Session, key: str): | ||
| async def read_configuration_value(self, session: AsyncSession, key: str): |
There was a problem hiding this comment.
We could probably just do a full-blown s/sa.orm.Session/AsyncSession/g through the whole repo because there's nowhere that we're actually using a sync session to me knowledge. I guess the imports will also need to be fixed up too, but I wonder how pervasive it is now
There was a problem hiding this comment.
There's only 10 left now, I can replace those in a follow-up PR.
CodSpeed Performance ReportMerging #15062 will not alter performanceComparing Summary
|
bunchesofdonald
force-pushed
the
mypy-models
branch
from
28046dc
to
b80a490
Compare
| @@ -86,7 +86,7 @@ class or a Block interface class | |||
| """ | |||
|
|
|||
|
|
|||
| def _collect_nested_reference_strings(obj: Dict): | |||
| def _collect_nested_reference_strings(obj: Dict) -> List[str]: | |||
There was a problem hiding this comment.
I'm surprised mypy lets a naked generic like Dict though, is there a mypy setting that's letting this fly?
There was a problem hiding this comment.
I believe mypy just treats it as Dict[Any, Any], no particularly special config, though I am technically using a config different than what's in the repo to get stricter validation that we can't do codebase-wide yet:
[mypy]
plugins =
pydantic.mypy
ignore_missing_imports = True
follow_imports = normal
disallow_untyped_defs = True
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
bunchesofdonald
force-pushed
the
mypy-models
branch
2 times, most recently
from
23af86a
to
7fce72e
Compare
bunchesofdonald
force-pushed
the
mypy-models
branch
from
7fce72e
to
5328344
Compare
| flow_filter: Optional[schemas.filters.FlowFilter] = None, | ||
| flow_run_filter: Optional[schemas.filters.FlowRunFilter] = None, | ||
| task_run_filter: Optional[schemas.filters.TaskRunFilter] = None, | ||
| deployment_filter: Optional[schemas.filters.DeploymentFilter] = None, | ||
| work_pool_filter: Optional[schemas.filters.WorkPoolFilter] = None, | ||
| work_queue_filter: Optional[schemas.filters.WorkQueueFilter] = None, |
This gets all of the files in
/modelsto pass mypy checks.