Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server side json variables #13500

Merged
merged 8 commits into from
May 22, 2024
Merged

server side json variables #13500

merged 8 commits into from
May 22, 2024

Conversation

jakekaplan
Copy link
Contributor

@jakekaplan jakekaplan commented May 21, 2024 •
edited
Loading

This pr enables Variables to be stored as any JSON type server side.

It includes:

  • Variable.value formerly could only be str now it can be any JSON type including int | str | float | None | dict | list
  • Sqlite and Postgres migrations that are reversed if needed, converting string stored types to json stored types. This utilizes passing the variable values through python to convert them correctly to json (and back).
  • Removes VariableFilterValue, this does not make sense as a valid filter and we are okay with removing it

@jakekaplan jakekaplan added the enhancement An improvement of an existing feature label May 21, 2024
@jakekaplan jakekaplan marked this pull request as ready for review May 21, 2024 19:01
@jakekaplan jakekaplan requested review from a team and zangell44 as code owners May 21, 2024 19:01
@jakekaplan jakekaplan changed the title json variables server side json variables May 21, 2024
chrisguidry
chrisguidry approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love the migration!

@jakekaplan jakekaplan merged commit 7c37407 into main May 22, 2024
19 of 25 checks passed
@jakekaplan jakekaplan deleted the json-variables branch May 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakekaplan @chrisguidry