Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local retries #1228

Merged
merged 8 commits into from
Jul 13, 2019
Merged

Local retries #1228

merged 8 commits into from
Jul 13, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jul 12, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR implements "local retries" in the Cloud Task Runner. Essentially, we found that tasks which request fast retries tend to eat up infrastructure in a way that just felt unnecessary. This PR will retry tasks whose retry start time is <= 1 minute away by sleeping in the local process. This prevents additional infrastructure spin ups.

@cicdw cicdw requested review from jlowin and joshmeek July 12, 2019 22:03
@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #1228 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@cicdw cicdw requested review from jlowin and removed request for jlowin July 13, 2019 18:28
@cicdw cicdw merged commit 02ed0ca into master Jul 13, 2019
@cicdw cicdw deleted the local-retries branch July 13, 2019 18:46
abrookins pushed a commit that referenced this pull request Mar 15, 2022
…-ui/vue-router-4.0.13

Bump vue-router from 4.0.12 to 4.0.13 in /orion-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants