Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private docker registries #1028

Merged
merged 6 commits into from
May 15, 2019
Merged

Private docker registries #1028

merged 6 commits into from
May 15, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented May 15, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR tentatively adds the ability for Cloud users to pull Flow images from private docker registries.

Why is this PR important?

Security!

@cicdw cicdw requested review from jlowin and joshmeek as code owners May 15, 2019 17:41
@codecov
Copy link

codecov bot commented May 15, 2019 •
edited
Loading

Codecov Report

Merging #1028 into master will decrease coverage by 0.34%.
The diff coverage is 37.5%.

@cicdw cicdw merged commit 0094f5b into master May 15, 2019
@cicdw cicdw deleted the private-docker branch May 15, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeek joshmeek joshmeek approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdw @joshmeek