Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the custom patched SSE server transport in favor of the upstream implementation from mcp and updates the dependency accordingly.
- Removed the custom patched SSE server transport (src/fastmcp/low_level/sse_server_transport.py)
- Updated the import in src/fastmcp/server/http.py to use the upstream transport
- Bumped the mcp dependency version to 1.8.1 in pyproject.toml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/fastmcp/server/http.py | Updated to import the upstream SSEServerTransport |
| src/fastmcp/low_level/sse_server_transport.py | Removed the custom patched transport implementation |
| pyproject.toml | Updated mcp dependency version to ensure compatibility with the upstream transport |
Contributor
|
FYI this (modelcontextprotocol/python-sdk@1cb7407) was released in |
Member
Author
|
Thank you @JonZeolla! |
jlowin
added
the
bug
jordicore
pushed a commit
to jordicore/fastmcp
that referenced
this pull request
Jul 2, 2025
Remove patch and use upstream SSEServerTransport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With modelcontextprotocol/python-sdk#659 merged, we can remove the patched transport and depend on the upstream again. This PR's tests will not pass until mcp 1.8.2 is released.