feat(ClubDoDorama): add presence - #11189
Open
cuscuzleitado wants to merge 5 commits into
Open
Conversation
Signed-off-by: cuscuzleitado <148428177+cuscuzleitado@users.noreply.github.com>
Signed-off-by: cuscuzleitado <148428177+cuscuzleitado@users.noreply.github.com>
Signed-off-by: cuscuzleitado <148428177+cuscuzleitado@users.noreply.github.com>
Contributor
🖼️ Activity asset previewAsset inspection complete. No pixels were harmed in the making of this comment. 🤖 ClubDoDorama (
|
| Preview | Source | URL |
|---|---|---|
 |
logo | https://i.imgur.com/NG3A7fd.png |
 |
code (presence.ts) |
https://i.imgur.com/eeVRVDN.png |
Beep boop — I refresh this comment on every push, so no need to scroll. 🤖
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Okay, I’ll take care of that later. Right now, I need to get some rest… |
Signed-off-by: cuscuzleitado <148428177+cuscuzleitado@users.noreply.github.com>
Signed-off-by: cuscuzleitado <148428177+cuscuzleitado@users.noreply.github.com>
skullysmods
requested changes
Sep 13, 2026
Comment on lines
+10
to
+11
| "en": "Show on Discord which drama you are watching on ClubDoDorama.", | ||
| "pt": "Mostre no Discord qual dorama você está assistindo no ClubDoDorama." |
Member
There was a problem hiding this comment.
Use official description from service
Comment on lines
+92
to
+93
| presenceData.smallImageKey | ||
| = 'https://i.imgur.com/eeVRVDN.png' |
Member
There was a problem hiding this comment.
You can use Assets.Search instead
Comment on lines
+99
to
+100
| presenceData.smallImageKey | ||
| = 'https://i.imgur.com/eeVRVDN.png' |
| "regExp": "^https?[:][/][/]([a-z0-9-]+[.])*clubdodorama[.]com[/]", | ||
| "version": "1.0.0", | ||
| "logo": "https://i.imgur.com/NG3A7fd.png", | ||
| "thumbnail": "https://i.imgur.com/NG3A7fd.png", |
Member
There was a problem hiding this comment.
Thumbnail should be a landscape promotional image or screenshot—not the logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Rich Presence support for ClubDoDorama (clubdodorama.com), a Korean/Asian drama streaming site.
The presence detects three types of pages:
When available, it uses the drama/movie poster (via TMDB) as the large image. The drama/movie name is also used in the "name" field, so it shows up next to the activity icon on Discord instead of the application name.
Note: the site's video player is a third-party iframe, so it isn't possible to read the exact video progress (play/pause/time) due to browser CORS restrictions. Because of that, the timestamp shown is based on when the person opened the page, not the actual video playback time.
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected