Repository navigation
Add Nova ZK SoulKey minting UI scaffold - #144
Pray4Lovee wants to merge 295 commits into
Conversation
…-scripts Add LumenCardKit v2.0 toolkit and workflow
…with-concurrent-processing Parallelize bloom filter matching
…bridgeclaimbutton-w5ke09 Add GitHub attribution helpers and tests
…bootstrap-repo Add Nova Phase 0 bootstrap
…er-bot Add SEI auto-compounder bot toolkit
…r-chain-support Add chain metadata to LumenCardKit receipts
Add Nova automation scripts and Docker deployment
…val-error Fix surplus logging format in EVM module
Add MsgClaim handling and responses
…kcymv Add keeper claim handler and tests
…md/go_modules-c775a3108c chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /sei-wasmd in the go_modules group across 0 directory
…wasm/cw1155/cargo-573969d7da chore(deps): bump the cargo group across 0 directory with 1 update
…bridgeclaimbutton Add GitHub attribution helpers and tests
…-for-sei-msgclaim Add msg_claim deployment helper
…nsaction-workflow Harden USDC paymaster workflow for Hyperliquid broadcast
…bridgeclaimbutton-fr560e Add GitHub attribution helpers and tests
…master-flow Add mainnet USDC paymaster workflow
…b-action Add golangci-lint GitHub Action workflow
…bridgeclaimbutton-fgpyey Add GitHub attribution helpers and tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| try { | ||
| const selectedSigils = selected.map((i) => sigils[i]); | ||
|
|
||
| const proofRes = await fetch("/api/sigils/proofs", { | ||
| method: "POST", | ||
| body: JSON.stringify({ |
There was a problem hiding this comment.
[P1] Reset selection when sigil list changes
The minting handler derives selectedSigils from indices stored in selected, but the component never clears or validates that state when user changes or after a fresh /api/sigils fetch. If a user switches accounts or their sigil list shrinks to fewer than three items, the button remains enabled (selected.length === 3) and selected.map((i) => sigils[i]) will yield undefined entries, causing selectedSigils.map((sigil) => sigil.tokenId) to throw Cannot read properties of undefined. Consider resetting selected when user updates or guarding against missing sigils before mapping.
Useful? React with 👍 / 👎.
2 participants
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d97d4c77448322917fa3ad6b5ae76c