Skip to content

Add chain-themed SoulSigil SVG generator - #136

Open
Pray4Lovee wants to merge 295 commits into
mainfrom
codexprepare-vaultscannerv2-with-sigil-gallery
Open

Pray4Lovee wants to merge 295 commits into
mainfrom
codexprepare-vaultscannerv2-with-sigil-gallery

Conversation

@Pray4Lovee

Copy link
Copy Markdown
Owner

Summary

  • add a utility to render SoulSigil SVGs with chain-specific glyph overlays and gradients
  • expose the generator through the kinbridge package index for external consumers

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_68d97d0e99348322b6be667d97ea06af

…bridgeclaimbutton-w5ke09

Add GitHub attribution helpers and tests
…bootstrap-repo

Add Nova Phase 0 bootstrap
…er-bot

Add SEI auto-compounder bot toolkit
…r-chain-support

Add chain metadata to LumenCardKit receipts
Add Nova automation scripts and Docker deployment
…val-error

Fix surplus logging format in EVM module
…kcymv

Add keeper claim handler and tests
…md/go_modules-c775a3108c

chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /sei-wasmd in the go_modules group across 0 directory
…wasm/cw1155/cargo-573969d7da

chore(deps): bump the cargo group across 0 directory with 1 update
…bridgeclaimbutton

Add GitHub attribution helpers and tests
…-for-sei-msgclaim

Add msg_claim deployment helper
…nsaction-workflow

Harden USDC paymaster workflow for Hyperliquid broadcast
…bridgeclaimbutton-fr560e

Add GitHub attribution helpers and tests
…master-flow

Add mainnet USDC paymaster workflow
…b-action

Add golangci-lint GitHub Action workflow
…bridgeclaimbutton-fgpyey

Add GitHub attribution helpers and tests

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting


const radius = 40 + (amount % 20);
const fill = COLOR_MAP[chain] ?? FALLBACK_COLOR;
const jitter = moodHash ? parseInt(moodHash.slice(0, 2), 16) % 10 : 3;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Guard against NaN jitter when moodHash malformed

The jitter calculation assumes any provided moodHash contains two valid hex digits. When callers pass an empty string or non‑hex content (which is still a truthy string per the interface), parseInt(moodHash.slice(0, 2), 16) returns NaN. That NaN is interpolated into the path commands (e.g., a ${radius},${jitter} and the default overlay path) producing attributes like NaN that prevent the SVG from rendering. It would be safer to fallback to the default jitter when the parse result is NaN or the input is shorter than expected.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants