This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Use ip command for VPN segment - fix #1125 #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done if we want to show a public IP, internal IP, or a VPN. In the VPN case, what we actually want is to display an indicator that a VPN is active, instead of the VPN IP itself. We parse the IP here anyway, because we want to save some specific code there.
|
Hi @Shini31 , I made some changes to your code ninja-style. The code now runs without externals and is now the same for checking for VPN, as well as parsing public and internal IPs. Could you double check if everything still works for you and report here back? That would be awesome. Thanks |
Syphdias
approved these changes
Feb 17, 2019
|
@Syphdias Thanks for the review. As I am not the originator of this PR, it seems like I cannot apply your suggestions. Do you mind if I just copy them over, or do you want to create a separate branch where I can cherry-pick them? |
|
Thx @Shini31 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so much for opening a PR for P9k! Many of our best features and segments have come from the community, and we are excited to see your contribution.
To help you make the best PR, here are some guidelines:
masterbranch is our stable branch, and thenextbranch is our development branch. If you are submitting a bug fix, please file your PR againstmaster. If it is a new feature, enhancement, segment, or something similar, please submit it againstnext. For more information, please see our Developer's Guide.testdirectory. Please add unit tests for anything new you have developed! If you aren't sure how to do this, go ahead and file your PR and ask for help!Once you have submitted your PR, P9k core contributors will review the code and work with you to get it merged. During this process, we might request changes to your code and discuss different ways of doing things. This is all part of the open source process, and our goal is to help you create the best contribution possible for P9k
=).Please follow this template for creating your PR:
Title
Please make the title of your PR descriptive! If appropriate, please prefix the title with one of these tags:
Description
Please describe the contribution your PR makes! Screenshots are especially helpful, here, if it's a new segment.
If your PR is addressing an issue, please reference the Issue number here.
Questions
Is there something in your PR you're not sure about or need help with? Is there a particular piece of code you would like feedback on? Let us know here!