Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find shell integration script for VS Code 1.94+ #5047

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

andyleejordan
Copy link
Member

It got moved. Pulling this out of the OneBranch signing PR. See microsoft/vscode#227244

@andyleejordan
Copy link
Member Author

/cc @Tyriar though I'm still looking at the envMixin of https://github.com/microsoft/vscode/blob/main/src/vs/platform/terminal/node/terminalProcess.ts#L210 et. al. and debugging trying to confirm if I need to manually add any environment variables to our terminal process launch

this.consoleTerminal = vscode.window.createTerminal(terminalOptions);

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit a1490e5 Sep 18, 2024
7 checks passed
@andyleejordan andyleejordan deleted the shell-integration-moved branch September 18, 2024 21:29
@Tyriar
Copy link
Contributor

Tyriar commented Sep 19, 2024

To confirm what needs to be set I'd check the environment the terminal is being created with. Variables of interest are VSCODE_NONCE (which you're unable to set), VSCODE_STABLE (which blocks some experimental stuff from working in stable)

@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Oct 30, 2024
mawosoft added a commit to mawosoft/misc-scripts that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants