-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a CustomRequest to disconnect the dotnet debugger from attach sessions. #4704
Conversation
@andyleejordan should we bring in https://www.npmjs.com/package/@vscode/debugprotocol as a dependency for strong typing of the custom disconnect request? esbuild should tree shake it and not increase the overall file size much. |
Yes! |
Since the only thing we need to bring in is an interface, it should be fine as a dev dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just me being annoying with spacing and wishing ESLint were better at things like that.
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
@andyleejordan Prettier is focused on whitespace stuff and interoperates with ESLint, we can explore adding it to the toolchain. |
Test Failure on 5.1 doesn't appear to be related to this PR, so I'm going to merge it. |
PR Summary
The vscode
stopDebugging
API when used with the dotnet debugger would kill the powershell process if it was in attach mode, so we use acustomRequest
DAP message to disconnect the dotnet debugger since there is no vscode direct API for disconnecting the debug session.Fixes #4702
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready