Respect file path casing in extension commands - #4703
Merged
Andy Jordan (andyleejordan) merged 2 commits intoAug 17, 2023
Conversation
Per https://nodejs.org/en/docs/guides/working-with-different-filesystems we should really just keep the file path we're given, no "normalizing" to be done especially since it is wrong to infer from the OS if the filesystem is case-sensitive or not. Gone are the days where Windows and macOS could be presumed case-insensitive, they now both support and are often found with with case-sensitive filesystems. Plus, there was really no reason to be doing this in the first place. Tested interactively, this works just fine since the VS Code APIs we're using handle case-insensitivity for us. Resolves #2960.
Member
Author
|
Patrick Meinecke (@SeeminglyScience) I couldn't find a way to test |
Andy Jordan (andyleejordan)
force-pushed
the
andyleejordan/fix-newfile-casing
branch
2 times, most recently
from
August 17, 2023 02:10
edd0e05 to
6276eae
Compare
Patrick Meinecke (SeeminglyScience)
approved these changes
Aug 17, 2023
Patrick Meinecke (SeeminglyScience)
left a comment
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! One minor possible typo correction in a comment
The response is now `Completed` or `Failed` and returned appropriately. `NewFile` now takes (optional) content and fills the new file with it (which is all the VS Code API can do). `OpenFile` doesn't throw a cryptic error in the terminal if the file isn't found. The status bar messages are now properly disposed.
Andy Jordan (andyleejordan)
force-pushed
the
andyleejordan/fix-newfile-casing
branch
from
August 17, 2023 22:03
06f6c2f to
ae72307
Compare
Andy Jordan (andyleejordan)
enabled auto-merge
August 17, 2023 22:05
Andy Jordan (andyleejordan)
added this pull request to the merge queue
Aug 17, 2023
Andy Jordan (andyleejordan)
deleted the
andyleejordan/fix-newfile-casing
branch
August 17, 2023 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://nodejs.org/en/docs/guides/working-with-different-filesystems we should really just keep the file path we're given, no "normalizing" to be done especially since it is wrong to infer from the OS if the filesystem is case-sensitive or not. Gone are the days where Windows and macOS could be presumed case-insensitive, they now both support and are often found with with case-sensitive filesystems. Plus, there was really no reason to be doing this in the first place. Tested interactively, this works just fine since the VS Code APIs we're using handle case-insensitivity for us.
Resolves #2960.