Skip to content

Conversation

@rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Dec 17, 2020

PR Summary

  • Updates dependencies in the extension that were causing build failures on macOS.
  • Addresses npm audit issues
  • Moves the vscode engine version to 1.52 (the minimum that fixed the build failures)
  • Fixes use of the TreeDataProvider API for the command explorer, which was causing another build issue

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

package.json Outdated
"vscode-extension-telemetry": "~0.1.6",
"vscode-languageclient": "^7.0.0-next.14",
"vscode-languageserver-protocol": "^3.16.0-next.11"
"vscode-languageclient": "^7.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good opportunity to use ~ everywhere instead of ^

@rjmholt rjmholt merged commit cc74a42 into PowerShell:master Dec 17, 2020
@rjmholt rjmholt deleted the fix-macos-ci branch December 17, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants