Skip to content

Enable pwsh dotnet global tool in discovery #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmholt merged 1 commit into from
Feb 28, 2020
Merged

Enable pwsh dotnet global tool in discovery #2503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,13 +180,10 @@ export class PowerShellExeFinder {
break;
}

// TODO:
// Enable this when the global tool has been updated
// to support proper argument passing.
// Currently it cannot take startup arguments to start PSES with.
//
// Look for the .NET global tool
// yield this.findPSCoreDotnetGlobalTool();
// Some older versions of PowerShell have a bug in this where startup will fail,
// but this is fixed in newer versions
yield this.findPSCoreDotnetGlobalTool();

// Look for PSCore preview
yield this.findPSCorePreview();
Expand Down