Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Pester Describe block strings with single quotes inside it #1729

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Handle Pester Describe block strings with single quotes inside it #1729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b12035
Handle describe block strings with single quotes inside it.
bergmeister Jan 26, 2019
2a27168
fix replace call to handle expression with more than one single quote…
bergmeister Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix replace call to handle expression with more than one single quote… 
… as well
  • Loading branch information
@bergmeister
bergmeister committed Jan 29, 2019
commit 2a2716880645e807d8b1934f6bbaf4b88cae9cfd
4 changes: 2 additions & 2 deletions src/features/PesterTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ export class PesterTestsFeature implements IFeature {

if (describeBlockName) {
launchConfig.args.push("-TestName");
// Escape single quotes inside double quotes
// Escape single quotes inside double quotes by doubling them up
if (describeBlockName.includes("'")) {
describeBlockName = describeBlockName.replace("'", "''");
describeBlockName = describeBlockName.replace(/'/g, "''");
}
launchConfig.args.push(`'${describeBlockName}'`);
}
Expand Down