(GH-1413) Resolve promise correctly in Folding feature #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in PR PowerShell#1414 the Folding provider was updated, however the promise resolution was incorrect. This caused the grammar load to never trigger the Then command. This commit instead uses the correct way to return the value for the promise and, when then triggers the Then statement correctly.
|
Ping @rkeithhill |
rjmholt
pushed a commit
that referenced
this pull request
Jul 11, 2018
Previously in PR #1414 the Folding provider was updated, however the promise resolution was incorrect. This caused the grammar load to never trigger the Then command. This commit instead uses the correct way to return the value for the promise and, when then triggers the Then statement correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously in PR #1414 the Folding provider was updated, however the promise
resolution was incorrect. This caused the grammar load to never trigger the
Then command. This commit instead uses the correct way to return the value
for the promise and, when then triggers the Then statement correctly.
Fixes #1413.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready