Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community_snippets.md #1395

Merged
merged 3 commits into from
Jul 2, 2018
Merged

Conversation

fullenw1
Copy link
Contributor

@fullenw1 fullenw1 commented Jul 1, 2018

PR Summary

Added the Send-MailMessage snippet

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress

fullenw1 added 2 commits July 1, 2018 20:47
Added the Mail snippet
Renamed the snippet
#### Snippet

```json
"Send-MailMessage": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend naming the snippet something other than the command name. This can get confusing when you think you're autocompleting the command name but then get this snippet. We have been using a naming convention in the extension where "examples" start with ex-. Perhaps you call this snippet ex-send-mail-message?

@fullenw1 fullenw1 closed this Jul 2, 2018
@fullenw1
Copy link
Contributor Author

fullenw1 commented Jul 2, 2018

Leave a comment

@fullenw1 fullenw1 reopened this Jul 2, 2018
Snippet renamed to ex-Send-MailMessage which stands for "example of Send-MailMessage"
@fullenw1
Copy link
Contributor Author

fullenw1 commented Jul 2, 2018

Snippet renamed to ex-Send-MailMessage

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks!

@TylerLeonhardt TylerLeonhardt merged commit f54a611 into PowerShell:master Jul 2, 2018
rjmholt pushed a commit that referenced this pull request Jul 11, 2018
* Update community_snippets.md

Added the Mail snippet

* Update community_snippets.md

Renamed the snippet

* Update community_snippets.md

Snippet renamed to ex-Send-MailMessage which stands for "example of Send-MailMessage"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants