Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issue template tweaks and add PSSA template #1321

Merged

Conversation

bergmeister
Copy link
Contributor

PR Summary

Enhances PR #1320

  • Add PSSA template
  • Rename colorization template to start with the same name as the bug template to group bug templates together in the UI
  • Use 🌈 emoji in colorization for more awesomeness

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
  • No emojis were harmed during this PR

@tylerl0706 🦄

@rkeithhill
Copy link
Contributor

Dang! Mentioning @tylerl0706 did not automatically add him as a reviewer. Back to the docs.

---

* Please submit PSScriptAnalyzer issues to the
[PSScriptAnalyzer](https://github.com/powershell/PSScriptAnalyzer/issues) repo on GitHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if hyperlink's in the about: field would work? As a convenience it would be nice to click there without having the extra Get Started button click.

Copy link
Contributor Author

@bergmeister bergmeister May 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they don't work, I tried in the test repo here once with a plain link and once with a markdown link.
It seems GitHub itself don't have their own website on GitHub so we can't even fix that...

@rkeithhill
Copy link
Contributor

Would you mind removing the @tylerl0706 mention in the PR template. Doesn't seem to automatically add him as a reviewer so no point in having it.

@bergmeister
Copy link
Contributor Author

Ok. Done. I find it better this way because as someone who does a PR it gives me some progress when I see that someone gets assigned whilst waiting for PR feedback.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😀 thanks @bergmeister 🎉

@rkeithhill rkeithhill merged commit 34bafe7 into PowerShell:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants