added functionality to install the VSCode context menus. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is now always added to the search path
|
|
TylerLeonhardt
requested review from
daviwil,
TylerLeonhardt,
rkeithhill and
rjmholt
|
This is great! Thanks for contributing 😃 FYI, we got another PR that touched this file so their may be a very small merge conflict coming your way. Changelog stuff. When you get a chance, sign the CLA so we can get this in 👍 |
|
@detlefs did you want to resolve the conflict so we can get this in :) |
rjmholt
approved these changes
May 11, 2018
|
Although this is stale, this would still be nice to have. Maybe we could resolve the conflicts ourselves and merge in? |
rkeithhill
reviewed
Jul 10, 2018
scripts/Install-VSCode.ps1
Outdated
| @@ -202,4 +213,4 @@ if (!($IsLinux -or $IsOSX)) { | |||
| } | |||
| else { | |||
| Write-Error "This script is currently only supported on the Windows operating system." | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Should probably add back in the final newline.
rkeithhill
approved these changes
Jul 10, 2018
rjmholt
pushed a commit
that referenced
this pull request
Jul 11, 2018
* Add functionality to install the VSCode context menus. * VSCode is now always added to the search path
|
Ooo need to add this to the signing process so we can release this on the Gallery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functionality to install the VSCode context menus. Also, VSCode is now always added to the search path