Skip to content

Finish tslint integration, fails build on tslint error #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2018
Merged

Finish tslint integration, fails build on tslint error #1172

merged 3 commits into from
Jan 23, 2018

Conversation

rkeithhill
Copy link
Contributor

No description provided.

@rkeithhill rkeithhill requested review from daviwil and kapilmb January 23, 2018 04:57
daviwil
daviwil approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rkeithhill rkeithhill merged commit 1371181 into master Jan 23, 2018
@TylerLeonhardt
Copy link
Member

sorry I'm late! LGTM 👍

@TylerLeonhardt TylerLeonhardt deleted the rkeithhill/finish-tslint-integration branch February 21, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

@kapilmb kapilmb Awaiting requested review from kapilmb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkeithhill @TylerLeonhardt @daviwil