Merge 1.4.3 release #1033
Merged
Merge 1.4.3 release #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on conflict This change fixes an issue that was illuminated by the AzureRM Tools extension where the `fs.appendFile` method provided by Node.js was not being called with the correct number of parameters. The AzureRM Tools extension loads up the AppInsights SDK for Node.js which in turn loads a module called Zone.js. Zone.js replaces built-in Node.js modules like `fs` to instrument their function calls. The instrumented version of that module was not as permissive on our missing `appendFile` parameter so it threw an exception which ultimately prevented the PowerShell extension from loading. This issue was fixed by populating the `callback` parameter of the `appendFile` function so that the instrumented wrapper operates correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release contains a fix for #1016, an issue which has been affecting quite a few users since VS Code 1.16.0 was released.