Restarting PowerShell session doesn't retain PowerShell Core selection

[daviwil]

For some reason when I select one of the new PowerShell Core entries from the session menu, let the new session load, then try to reload it, it goes back to selecting the built-in Windows PowerShell install. I would expect it to reload the session that was selected most recently.

[rkeithhill]

Same thing happens when you switch to built-in x86. :-(

[daviwil]

Weird... Not sure how that broke!

[daviwil]

In other words, I don't think your changes caused it :)

[rkeithhill]

It's like you're a mind reader. :-p But that doesn't necessarily mean my change didn't break something. I hope not.

[daviwil]

I'm pretty sure it didn't, the more likely culprit is the changes around adoption of the newer vscode-languageclient library, that broke other stuff too.

[daviwil]

Ok, I'm wondering if this ever worked...

https://github.com/PowerShell/vscode-powershell/blob/master/src/session.ts#L713

[rkeithhill]

Guess that should be passing in the current sessionConfiguration, eh?

[daviwil]

Yep. I'm about to submit a PR