Variable hover/data tips not working in the debugger

[rkeithhill]

Please fill in these details so that we can help you!

System Details

• Operating system name and version: Windows 10 1607
• VS Code version: 1.5.3
• PowerShell extension version: 0.7.2
• Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.14393.187
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.187
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

I can no longer hover over a variable in the debugger and get a hover tip. This used to work not too long ago.

Attached Logs

In looking at the log, we return false for supportsEvaluateForHovers. Is that right? We do support hover though, right? OTOH I don't think our eval is side-effect free. Maybe that's why this is false?

[daviwil]

Hmmm, I think that parameter may cause it to be evaluated in the REPL but I'm not sure... Worth investigating though. I wonder if the debugger client has changed the way they request these? We're a little out of date with the latest protocol I think.

[rkeithhill]

Yeah, I've been "loosely" following debug protocol updates but I really need to sink my teeth into the updated protocol and see where we should update our implementation.

[rkeithhill]

And indeed it was the change to the "expensive" property on the Autos variable container that broke this. Not sure which is more painful - Auto not expanding by default or not having hover tips. I think it might be the latter. If I open Auto, it will now stay open.

[daviwil]

This is fixed in VS Code 1.6 now, right?

[rkeithhill]

I was lead to believe it would be fixed post 1.6. I tested it on the 1.7 insiders release but I'm seeing that it works in 1.6. Hmm...

[rkeithhill]

If VSCode thinks there are no duplicate variable names in non-expensive scopes it will display debug hover tips. I believe 1.7 and higher removes the whole "don't display debug hover on a duplicate variable name" check. What I do notice in 1.6 is that Autos isn't starting open during a debug session. I believe it used to do that. Sigh... Nothing like chasing a moving target. :-)

At this point, should we target 0.8.0 to coincide with the 1.7 VSCode release? If so, I can try to make sure this is all working correctly on the insider's build.

[rkeithhill]

This seems to be working correctly in VSCode Insider builds.

[daviwil]

Yep, working correctly for me too. Closing this.