Intellisense provides a lot of junk

[PrzemyslawKlys]

System Details

• Operating system name and version: Windows 10 Enterprise Insider
• VS Code version: 1.24.0

Copy / paste the following commands into the PowerShell Integrated Console, and paste the output here:

PS C:\Users\pklys\OneDrive - Evotec\Support\GitHub\PSPulsewayManager\Public> code -v
1.24.0
6a6e02cef0f2122ee1469765b704faf5d0e0d859
x64
PS C:\Users\pklys\OneDrive - Evotec\Support\GitHub\PSPulsewayManager\Public> $pseditor.EditorServicesVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
1      7      0      0


PS C:\Users\pklys\OneDrive - Evotec\Support\GitHub\PSPulsewayManager\Public> code --list-extensions --show-versions
aaron-bond.better-comments@1.2.5
abusaidm.html-snippets@0.2.1
alefragnani.Bookmarks@0.19.1
azemoh.one-monokai@0.3.4
ban.spellright@2.5.0
donjayamanne.githistory@0.4.1
DotJoshJohnson.xml@2.2.0
eamodio.gitlens@8.3.5
emilast.LogFileHighlighter@2.4.0
emmanuelbeziat.vscode-great-icons@2.1.33
Equinusocio.vsc-material-theme@2.1.0
felixfbecker.php-debug@1.12.3
gerane.Theme-dimmed-monokai@0.0.2
gharveymn.nightswitch@1.1.0
GrapeCity.gc-excelviewer@2.0.21
hdg.live-html-previewer@0.3.0
HookyQR.beautify@1.3.0
IBM.output-colorizer@0.1.2
ikappas.phpcs@1.0.5
ionutvmi.reg@0.0.2
JerryHong.autofilename@0.1.3
johnpapa.winteriscoming@0.7.1
KnisterPeter.vscode-github@0.28.1
mechatroner.rainbow-csv@0.3.0
ms-vscode.csharp@1.15.2
ms-vscode.PowerShell@1.7.0-insiders-557
ms-vsliveshare.vsliveshare@0.3.264
ms-vsts.team@1.136.0
redhat.java@0.26.0
robertohuertasm.vscode-icons@7.23.0
Shan.code-settings-sync@2.9.2
streetsidesoftware.code-spell-checker@1.6.10
streetsidesoftware.code-spell-checker-polish@1.0.0
vangware.dark-plus-material@1.1.3
vscjava.vscode-java-debug@0.9.0
vscjava.vscode-java-pack@0.3.0
vscjava.vscode-java-test@0.6.1
vscjava.vscode-maven@0.9.0
wayou.vscode-todo-highlight@0.5.12
whizkydee.material-palenight-theme@1.8.0
xaver.clang-format@1.6.2
zhuangtongfa.Material-theme@2.13.6
Zignd.html-css-class-completion@1.11.0
PS C:\Users\pklys\OneDrive - Evotec\Support\GitHub\PSPulsewayManager\Public> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.17672.1000
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17672.1000
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Actually enabled extensions (the list above has all installed). Probably would be better for you to give a command to get only enabled extensions right?

Issue Description

Intellisense is providing a lot of junk.

Notice how it was able to pick up the full Set-DriveSettings definition and what it proposes for filling in.

Attached Logs

I've attached lots of logs in different bug report. Let me know if you need more.

[rkeithhill]

Is a PowerShell Editor Services session running? Look in the lower right of the window and it should show the version of PowerShell it is using for the session:

If the session is not running you will not get any auto-completion other than what VSCode provides - which is just the tokens in your file.

[PrzemyslawKlys]

You are right. It may be that I didn't had the 5.1 running. That's because PowerShell crashes for me very often and I often kill the window. I often see PSAnalyzer being stuck for long time (where I've fixed something and it still complains for the next 2 minutes that variable has bad name or that I have half of the screen red because it didn't notice the change.

Below is what you get until you press -

But I guess that's expected?

[PrzemyslawKlys]

On other hand...

and here is the definition:

But it seems it's only proposed if it's out of parameters. If i remove -LogNameSearch and add - it will just suggest LogNameSearch.

[rkeithhill]

OK, so the PowerShell Editor Services session is running. The next couple of things to try to rule out is script analysis and codelens. You can disable them with the following settings:

  "powershell.scriptAnalysis.enable": false,
  "editor.codeLens": false,

[PrzemyslawKlys]

Added. Restarted

While the definition:

Editor is running. But like I said in earlier report it only proposes junk if you are our of 'your own' parameters.

[rkeithhill]

@PrzemyslawKlys In this case, the PS editor services is reporting no more completions back to VSCode e.g.:

    READ MESSAGE:
    
    {
      "jsonrpc": "2.0",
      "id": 764,
      "method": "textDocument/completion",
      "params": {
        "textDocument": {
          "uri": "file:///c%3A/Users/Keith/GitHub/rkeithhill/vscode-powershell/examples/DebugTest.ps1"
        },
        "position": {
          "line": 61,
          "character": 5
        }
      }
    }

    WRITE MESSAGE:
    
    {
      "jsonrpc": "2.0",
      "id": "764",
      "result": []
    }

What you are seeing in the completion list above is provided by VSCode and it represents matching tokens (those starting with -) in your file.

I'm looking around to see if there is a way to indicate to VSCode that there are no more valid completions in this situation. So far, I'm coming up with nothing.

[PrzemyslawKlys]

That's what I thought after a couple of your explanation posts above. It would be nice to know Editor Services are done with it's work and now you are using VSCode junk ;) Thanks for looking into this.

[PrzemyslawKlys]

I type this method... i even run F5 to make sure powershell is initilized before trying intellisense. And it seems VSCode picks the standard token that i used above '-eq' and not the one proposed. I press CTRL+SPACE multiple times.

[PrzemyslawKlys]

Here is another example. As you can see it's not showing any good help for -Bold which is [bool[]] while it shows [UnderlineStyle[]] properly.

The Add-WordText is available here: https://github.com/EvotecIT/PSWriteWord/blob/master/Public/PSWordParagraph.ps1

Maybe it's just the way I use it...

[TylerLeonhardt]

Hey @PrzemyslawKlys,

Thanks for the gifs, they're really helpful! So I think the gif about Get-Test -Change is a performance bug. I think that if you had waited a bit longer, you would have gotten a response. We're working on addressing perf-related issues - we've gotten a lot of feedback on them.

Your second gif, I think, is actually a limitation of PowerShell. If you load that cmdlet Add-WordText into a regular console, do you get completions for the bool[]?

[PrzemyslawKlys]

Hey @tylerl0706 ,

You are right. I get same behaviour in ISE and powershell for bool[]. As for the 1st example it seems variable type needs to defined. If it's not defined you won't get completion in ISE either. When I changed it to bool it works straight away.

So I guess in both cases it's kind of expected although confusing.

Przemek

[TylerLeonhardt]

Both the ISE and VSCode PowerShell get completions via TabExpansion2 which is built in to PowerShell.

Definitely open an issue on PowerShell voicing this so we can fix it there 😃

If TabExpansion2 doesn't give VSCode any results, VSCode tries to "help" by supplying completions of things you've typed previously or common PowerShell things. You might be able to disable these but I'm not sure off the top of my head - I think that's really on VSCode.

[rjmholt]

@PrzemyslawKlys, to import those types properly, you might want to try the using keyword. You might get better intellisense then as well.