PSEdit not saving remote files

[muzzar78]

@daviwil - Could this issue be related to the following?

vscode-powershell/src/features/RemoteFiles.ts

Lines 11 to 24 in aa86c7e

	// NOTE: The following two DidSaveTextDocument* types will
	// be removed when #593 gets fixed.
	export interface DidSaveTextDocumentParams {
	/**
	* The document that was closed.
	*/
	textDocument: TextDocumentIdentifier;
	}
	export namespace DidSaveTextDocumentNotification {
	export const type = new NotificationType<DidSaveTextDocumentParams, void>('textDocument/didSave');
	}

When I remote into a server within the integrated terminal, run psedit the file appears in VSCode. However, when I make an edit and save the file the changes aren't getting saved back to the remote server. I have attached the verbose log output. https://github.com/PowerShell/vscode-powershell/files/1309888/vscode-powershell-psedit.zip

[djobin]

Hi!
I see the same behaviour... except, I can remotely edit .ps1 files and it gets commited back to the remote server, BUT when editing other file types (.cmd, .txt, .log, etc.) it does not get synced back.

vs code : 1.17
ps extensions : 1.4.3

[muzzar78]

Hi,
I can confirm the behaviour I'm seeing is the same as @djobin. Saving ps1 files do get committed back to the remote host but other extensions don't.

[muzzar78]

Here is the logic - it checks if the languageId is powershell.

vscode-powershell/src/features/RemoteFiles.ts

Lines 60 to 63 in aa86c7e

	private isDocumentRemote(doc: vscode.TextDocument) {
	return doc.languageId === "powershell" &&
	doc.fileName.toLowerCase().startsWith(this.tempSessionPathPrefix);
	}

So the workaround is to set the language mode to PowerShell regardless of the extension of the remote file and then the remote save works. I have tested this and it worked for me.

[daviwil]

Thanks for looking into this Adam! I'll take that check out.

[OnurGumus]

This issue still exists if you use VSCode Powershell extension along with Powershell 7 for remote files.