Change v2 schema for parameter. #622
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,7 +136,7 @@ | |
| "cmdletParameters": { // naming pending? use only a single word as the name if possible | ||
| "items": { | ||
| "additionalProperties": false, | ||
| "required": ["name", "description", "type", "parameterSet"], | ||
| "properties": { | ||
| "name": { | ||
| "type": "string" | ||
|
|
@@ -146,42 +146,65 @@ | |
| "contentType": "markdown", | ||
| "tags": ["localizable"] | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "contentType": "markdown" | ||
| }, | ||
| "parameterSet" : { | ||
| "items": { | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "additionalProperties": false, | ||
| "required": [ "name" ], | ||
| "properties": { | ||
| "name": { | ||
| "type": "string" | ||
| }, | ||
| "position": { | ||
| "type": "string" | ||
| }, | ||
| "valueByPipeline": { | ||
| "type": "boolean" | ||
| }, | ||
| "valueByPipelineByPropertyName": { | ||
| "type": "boolean" | ||
| }, | ||
| "valueFromRemainingArguments": { | ||
| "type": "boolean" | ||
| }, | ||
| "isRequired": { // mandatory | ||
| "type": "boolean" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "applicable": { // ???? | ||
|
There was a problem hiding this comment. This is an Office only thing.. @theJasonHelmick was going to reach out and verify if this is still something they still need. There was a problem hiding this comment. This applicable attribute might need to be moved into parameterset.parameter There was a problem hiding this comment. i wasn't sure what it means (thus the ???) - there doesn't seem to be an actual parameter attribute property of this name There was a problem hiding this comment. It is used by the |
||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "minItems": 1, | ||
| "type": "array" | ||
| }, | ||
| "aliases": { | ||
| "type": "array", | ||
| "minItems": 1, | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "isDynamic": { | ||
| "type": "boolean" | ||
| }, | ||
| "allowedValues": { // parameterValueGroup | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "minItems": 1, | ||
| "type": "array" | ||
| }, | ||
| "defaultValue": { | ||
| "type": "string" | ||
| }, | ||
| "acceptWildcardCharacters": { | ||
| "type": "boolean" | ||
| }, | ||
|
|
@@ -194,7 +217,7 @@ | |
| "minItems": 1, | ||
| "type": "array" | ||
| }, | ||
| "commonParameters": { // This implies has cmdlet binding | ||
|
There was a problem hiding this comment. This is supposed to be optional. Not all commands implement cmdlet binding. |
||
| "type": "string", | ||
| "contentType": "markdown", | ||
| "tags": ["localizable"] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this now be an int?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it can, but i've not gone through the current examples to see if it's
"named"anywhereUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. PowerShell shows named parameters as
[int]::MinValue. But we show it asNamedin the markdown yaml block. So it is a data vs. rendering question.