Skip to content

Removed sha1-based MACs from default config #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2023
Merged

Removed sha1-based MACs from default config #706

merged 2 commits into from
Dec 1, 2023

Conversation

anmenaga
Copy link

PR Summary

Removed MACs (message authentication code algorithms) that are using broken SHA-1 hash algorithm from the default config.

@anmenaga anmenaga requested a review from tgauth November 30, 2023 19:50
tgauth
tgauth reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@tgauth tgauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a WINDOWS preprocessor definition here around the entire #define KEX_SERVER_MAC so that we capture the divergence from upstream?

@anmenaga anmenaga merged commit 4ee8dc6 into latestw_all Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgauth tgauth tgauth approved these changes

+1 more reviewer

@bialymic bialymic bialymic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmenaga @tgauth @bialymic