Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

BREAKING CHANGE: Rename module and align with DSC Resource Kit #6

Merged
merged 10 commits into from
Sep 26, 2018
Merged

BREAKING CHANGE: Rename module and align with DSC Resource Kit #6

merged 10 commits into from
Sep 26, 2018

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Sep 25, 2018 •
edited
Loading

  • First release of WmiNamespaceSecurityDsc.

This change is Reviewable

@johlju johlju changed the title Rename resource module and align with DscResource.Template Rename resource module and align with DSC Resource Kit Sep 25, 2018
@codecov-io
Copy link

codecov-io commented Sep 26, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@d49daa4). Click here to learn what that means.
The diff coverage is 16.83%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev       #6   +/-   ##
======================================
  Coverage       ?   16.83%           
======================================
  Files          ?        1           
  Lines          ?      101           
  Branches       ?        0           
======================================
  Hits           ?       17           
  Misses         ?       84           
  Partials       ?        0
Impacted Files Coverage Δ
...ces/WmiNamespaceSecurity/WmiNamespaceSecurity.psm1 16.83% <16.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49daa4...98f9152. Read the comment docs.

@johlju johlju added the needs review The pull request needs a code review. label Sep 26, 2018
@johlju johlju closed this Sep 26, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Sep 26, 2018
@johlju johlju reopened this Sep 26, 2018
@johlju johlju added the needs review The pull request needs a code review. label Sep 26, 2018
@johlju johlju changed the title Rename resource module and align with DSC Resource Kit BREAKING CHANGE: Rename resource module and align with DSC Resource Kit Sep 26, 2018
@johlju johlju added the breaking change When used on an issue, the issue has been determined to be a breaking change. label Sep 26, 2018
@johlju johlju changed the title BREAKING CHANGE: Rename resource module and align with DSC Resource Kit BREAKING CHANGE: Rename module and align with DSC Resource Kit Sep 26, 2018
johlju
johlju commented Sep 26, 2018
View reviewed changes
Copy link
Contributor Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 22 files at r1, 7 of 7 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit f9742f2 into PowerShell:dev Sep 26, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Sep 26, 2018
@johlju johlju deleted the update-module branch September 26, 2018 06:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johlju @codecov-io