This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Removed transform to computer name for local Principal #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Set() method includes code that transforms the domain variable to $env:computername when the domain is empty or when it is "BUILTIN". However, the subsequent calls to create a NTAccount and translate that account into a SID fail when the domain is set to $env:computername. The SID lookup works fine when the domain is set to empty string, "." or "BUILTIN".
|
Thanks for the contribution! |
|
@SteveL-MSFT - no problem. There's one more pull request in there for the changes to the Test method. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Set() method includes code that transforms the domain
variable to $env:computername when the domain is empty
or when it is "BUILTIN". However, the subsequent calls to
create a NTAccount and translate that account into a SID
fail when the domain is set to $env:computername.
The SID lookup works fine when the domain is set to
empty string, "." or "BUILTIN".
This change is