Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Keep AllUsers Scope for updated Core scripts #592

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
The scope of all PowerShell-Core scripts/modules was always changed f…
…rom AllUsers to CurrentUsers.

This is not the expected behaviour of course. if I installed a PowerShell-Core script for all users I'd expect it to still be installed for all users after calling Update-Script, which wasn't the case currently.
So the check for $script:IsCoreCLR was removed from the scope, since this ment for PowerShell-Core scripts/modules that they'd always be reinstalled into the user scope during updates, no matter the original scope of the PowerShell Core script/module.
Also bumped version number so it can be deployed.
  • Loading branch information
echalone committed Mar 27, 2020
commit 0ed1eadf49f2defc11948e8deb856a5a594db9ff
62 changes: 34 additions & 28 deletions src/PowerShellGet/PowerShellGet.psd1
Original file line number Diff line number Diff line change
@@ -1,40 +1,40 @@
@{
RootModule = 'PSModule.psm1'
ModuleVersion = '2.2.3'
ModuleVersion = '2.2.4'
GUID = '1d73a601-4a6c-43c5-ba3f-619b18bbb404'
Author = 'Microsoft Corporation'
CompanyName = 'Microsoft Corporation'
Copyright = '(c) Microsoft Corporation. All rights reserved.'
Description = 'PowerShell module with commands for discovering, installing, updating and publishing the PowerShell artifacts like Modules, DSC Resources, Role Capabilities and Scripts.'
PowerShellVersion = '3.0'
FormatsToProcess = 'PSGet.Format.ps1xml'
FunctionsToExport = @(
'Find-Command',
'Find-DSCResource',
'Find-Module',
'Find-RoleCapability',
'Find-Script',
'Get-CredsFromCredentialProvider',
'Get-InstalledModule',
'Get-InstalledScript',
'Get-PSRepository',
'Install-Module',
'Install-Script',
'New-ScriptFileInfo',
'Publish-Module',
'Publish-Script',
'Register-PSRepository',
'Save-Module',
'Save-Script',
'Set-PSRepository',
'Test-ScriptFileInfo',
'Uninstall-Module',
'Uninstall-Script',
'Unregister-PSRepository',
'Update-Module',
'Update-ModuleManifest',
'Update-Script',
'Update-ScriptFileInfo')
FunctionsToExport = @(
'Find-Command',
'Find-DSCResource',
'Find-Module',
'Find-RoleCapability',
'Find-Script',
'Get-CredsFromCredentialProvider',
'Get-InstalledModule',
'Get-InstalledScript',
'Get-PSRepository',
'Install-Module',
'Install-Script',
'New-ScriptFileInfo',
'Publish-Module',
'Publish-Script',
'Register-PSRepository',
'Save-Module',
'Save-Script',
'Set-PSRepository',
'Test-ScriptFileInfo',
'Uninstall-Module',
'Uninstall-Script',
'Unregister-PSRepository',
'Update-Module',
'Update-ModuleManifest',
'Update-Script',
'Update-ScriptFileInfo')

VariablesToExport = 'PSGetPath'
AliasesToExport = @('inmo', 'fimo', 'upmo', 'pumo')
Expand All @@ -55,6 +55,11 @@
ProjectUri = 'https://go.microsoft.com/fwlink/?LinkId=828955'
LicenseUri = 'https://go.microsoft.com/fwlink/?LinkId=829061'
ReleaseNotes = @'
### 2.2.4
Bug Fix

- Keep AllUsers scope for PowerShell Core script/modules as well (not just up to PS 5.1) when updating via Update-Script and Update-Module

### 2.2.3
- Update `HelpInfoUri` to point to the latest content (#560)
- Improve discovery of usable nuget.exe binary (Thanks bwright86!) (#558)
Expand Down Expand Up @@ -279,3 +284,4 @@ https://github.com/PowerShell/PowerShellGet/blob/master/CHANGELOG.md

HelpInfoURI = 'http://go.microsoft.com/fwlink/?linkid=855963'
}

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ function Get-InstallationScope()
)

if ( -not $PreviousInstallLocation.ToString().StartsWith($currentUserPath, [System.StringComparison]::OrdinalIgnoreCase) -and
-not $script:IsCoreCLR -and
(Test-RunningAsElevated)) {
$Scope = "AllUsers"
}
Expand Down