Do not enable PSAvoidTrailingWhitespace rule by default as it currently flags whitespace-only lines as well and users don't like it #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y flags whitespace-only lines as well
rjmholt
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite modern editors having the ability to eliminate redundant whitespace when saving the file automatically, people are still upset by PSSA pointing out whitespace for whitespace-only lines by the rule
PSAvoidTrailingWhitespace. Until the rule is customisable for that with a potential change of the default behaviour, it is probably better to not have this rule enabled by default. This rule got enabled by default in version1.8.0of the vscode extension along with other rules.References:
PowerShell/PSScriptAnalyzer#1033
PowerShell/PSScriptAnalyzer#1036
PowerShell/vscode-powershell#1429
PowerShell/vscode-powershell#1432