Fix issue with stat format on Linux #698
Conversation
| @@ -224,7 +224,7 @@ function Set-NamedPipeMode { | |||
| ) | |||
| chmod $DEFAULT_USER_MODE $PipeFile | |||
| if ($IsLinux) { | |||
| $mode = stat -c "%A" $PipeFile | |||
| $mode = stat -c "%a" $PipeFile | |||
There was a problem hiding this comment.
Out of my depth here but I assume we know that %A works on macOS? Also does the else below execute on Windows? Or maybe we don't call this function at all on Windows?
There was a problem hiding this comment.
@tylerl0706 almost certainly wrote and tested the script on macOS, so I'm assuming that works
There was a problem hiding this comment.
stat -f "%a" on macOS gives me something totally different
There was a problem hiding this comment.
stat -f "%A" gives me e.g. 700
| @@ -222,13 +222,20 @@ function Set-NamedPipeMode { | |||
| [string] | |||
| $PipeFile | |||
| ) | |||
|
|
|||
| if ($IsWindows) { | |||
| return | |||
There was a problem hiding this comment.
Wish there was a comment here to explain why this doesn't apply to Windows.
| } | ||
| else { | ||
| elseif ($IsMacOS) { |
There was a problem hiding this comment.
This function gets called only if they're on MacOS or Linux. So the "if Windows" check above and this elseif change isn't really needed. On the other hand, if we wanted to make it more robust, we could keep the Windows check in and remove the MacOS & Linux checks on line 328 and 334.
| if ($IsLinux) { | ||
| $mode = stat -c "%A" $PipeFile | ||
| $mode = stat -c "%a" $PipeFile |
There was a problem hiding this comment.
I could have sworn I tested on linux before shipping this... in any case, my bad and good find.
The
statusage in the startup script currently does not work on Linux.This changes the
%Ato%ato make it work.