Skip to content

PSReadLine integration #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Aug 22, 2018
Merged

PSReadLine integration #672

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5a6eba6
Add infrastructure for managing context
SeeminglyScience Jun 2, 2018
1930afe
Console related classes changes
SeeminglyScience Jun 2, 2018
7e26e4e
Rewrite command invocation operations for PSRL
SeeminglyScience Jun 2, 2018
ac44055
Rewrite direct SessionStateProxy calls
SeeminglyScience Jun 2, 2018
d2e1ceb
Pass feature flags to Start-EditorServicesHost
SeeminglyScience Jun 3, 2018
a507705
Address feedback and fix travis build error
SeeminglyScience Jun 3, 2018
a870ee2
Fix all tests except ServiceLoadsProfileOnDemand
SeeminglyScience Jun 3, 2018
190cc0c
Fix extra new lines outputted after each command
SeeminglyScience Jun 5, 2018
49db2ba
Remove unused field from InvocationEventQueue
SeeminglyScience Jun 5, 2018
379eee4
Remove copying of PDB's in build script
SeeminglyScience Jun 5, 2018
e16c823
Add AppVeyor tracking to branch 2.0.0
SeeminglyScience Jun 5, 2018
cc62dab
Fix ambiguous method crash on CoreCLR
SeeminglyScience Jun 5, 2018
7f2b5b8
first round of feedback changes
SeeminglyScience Jun 9, 2018
e19afe6
Some more feedback changes
SeeminglyScience Jun 9, 2018
afdfb43
add a bunch of copyright headers I missed
SeeminglyScience Jun 9, 2018
3575c79
remove KeyAvailable query
TylerLeonhardt Jul 22, 2018
6a3f7c9
Get the latest PSReadLine module installed
rjmholt Aug 1, 2018
cc10b91
Add PSReadLine installation to build script
rjmholt Aug 1, 2018
86ab115
the file should be downloaded as a .zip
TylerLeonhardt Aug 2, 2018
b51cc75
Address remaining feedback
SeeminglyScience Aug 19, 2018
1682410
Attempt to fix issue with native apps and input
SeeminglyScience Aug 19, 2018
d68fb70
Revert "Attempt to fix issue with native apps and input"
SeeminglyScience Aug 20, 2018
2968d1f
Fix build failure
SeeminglyScience Aug 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass feature flags to Start-EditorServicesHost
  • Loading branch information
@SeeminglyScience @TylerLeonhardt
SeeminglyScience authored and TylerLeonhardt committed Aug 2, 2018
commit d2e1ceb3b7feed997f4b18cc3abda1d82cc96ebd
3 changes: 2 additions & 1 deletion module/PowerShellEditorServices/Start-EditorServices.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,8 @@ try {
-BundledModulesPath $BundledModulesPath `
-EnableConsoleRepl:$EnableConsoleRepl.IsPresent `
-DebugServiceOnly:$DebugServiceOnly.IsPresent `
-WaitForDebugger:$WaitForDebugger.IsPresent
-WaitForDebugger:$WaitForDebugger.IsPresent `
-FeatureFlags:$FeatureFlags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that we only needed the colon for Switch parameters -- can this just be passed like the -BundledModulesPath parameter above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! That's a mistake :)


# TODO: Verify that the service is started
Log "Start-EditorServicesHost returned $editorServicesHost"
Expand Down