Enable formatOnType feature #370
Conversation
Using FilePosition file type causes JSON serializer to crash. Hence we use line and column numbers.
kapilmb
changed the title
| /// <summary> | ||
| /// Path of the file for which the formatting region is requested. | ||
| /// </summary> | ||
| public string fileUri; |
There was a problem hiding this comment.
Just a FYI, C# class properties should be capitalized like FileUri. The JSON serializer takes care of switching them to/from the correct case when sent through the language server protocol. Not a big deal to change right now, though
| return true; | ||
| }, true); | ||
|
|
||
| if (asts == null || asts.Count() == 0) |
There was a problem hiding this comment.
IEnumerable.Any() is way faster than IEnumerable.Count() because it checks if there's at least one item rather than iterating over the whole collection to get the full count. Doesn't matter at all in this case, just a helpful tip to pass along :)
| return null; | ||
| } | ||
|
|
||
| Func<IScriptExtent, int> getExtentWitdh = extent => extent.EndOffset - extent.StartOffset; |
There was a problem hiding this comment.
Since this is such a simple calculation that is used on 2 lines I'd just inline it instead of trying to make a reusable func, faster that way. Also not important to change for this PR
| Func<IScriptExtent, int> getExtentWitdh = extent => extent.EndOffset - extent.StartOffset; | ||
| var minDiff = getExtentWitdh(scriptFile.ScriptAst.Extent); | ||
| Ast minAst = scriptFile.ScriptAst; | ||
| foreach (var ast in asts) |
There was a problem hiding this comment.
Can you add a comment explaining what this loop is doing? Isn't perfectly clear why it's necessary.
kapilmb
changed the title
|
👍 |
|
@daviwil Thanks for the tips. I have updated the code to take into account all your suggestions. |
kapilmb
changed the title
|
If it's ready to merge, go for it! |
|
Thanks @daviwil! |
Added instructions to install Homebrew
No description provided.