Improve detection of runspace changes #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
force-pushed
the
daviwil/better-runspace-changed
branch
from
5e91f92 to
b1190be
Compare
This change adds new behavior that makes the detection of sudden runspace changes much more reliable. These changes were particularly necessary for detecting when we start debugging a runspace in a remote session since we don't get a PushRunspace notifications when that happens. This change also improves how we gather the prompt string just after a command is executed.
daviwil
force-pushed
the
daviwil/better-runspace-changed
branch
from
b1190be to
c6fdc6b
Compare
|
Gonna go ahead and merge this because I need it for another change. Feel free to leave feedback and I'll address it later this week. |
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
This change enables the user to configure their debugging sessions to launch a temporary Integrated Console each time they start the debugger. This is useful when debugging scripts or modules which use PowerShell classes or managed assemblies which cannot be reloaded within the same process. Resolves PowerShell#367.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new behavior that makes the detection of sudden runspace
changes much more reliable. These changes were particularly necessary for
detecting when we start debugging a runspace in a remote session since we
don't get a PushRunspace notifications when that happens.
This change also improves how we gather the prompt string just after a
command is executed.