Fix PSScriptAnalyzer module loading in new async AnalysisService #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the way that the PSScriptAnalyzer module gets loaded in the new asynchronous AnalysisService. Since we changed to using the InitialSessionState to load the module, we were unable to specify the exact version of the module we needed. This change goes back to an explicit Import-Module across the runspaces in the RunspacePool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the way that the PSScriptAnalyzer module gets loaded in
the new asynchronous AnalysisService. Since we changed to using the
InitialSessionState to load the module, we were unable to specify the
exact version of the module we needed. This change goes back to an
explicit Import-Module across the runspaces in the RunspacePool.