Skip to content

Sync breakpoints outside of debug sessions #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Sync breakpoints outside of debug sessions #1853

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
17e0d3f
Add NRT attribs polyfill
SeeminglyScience Jul 8, 2022
ec8806f
Add index and range polyfills
SeeminglyScience Jul 8, 2022
5e7a614
Add new services for syncing bps outside of DAP
SeeminglyScience Jul 8, 2022
ef47274
hook up bp sync services
SeeminglyScience Jul 8, 2022
f357fa1
Merge branch 'main' into bp-sync
SeeminglyScience Sep 13, 2023
bed8cc3
Fix build errors
SeeminglyScience Sep 13, 2023
347f500
Fix synced breakpoints for untitled files
SeeminglyScience Sep 13, 2023
17f3e8c
Fix tests
SeeminglyScience Sep 19, 2023
55c749d
Fix crash in debug config
SeeminglyScience Sep 20, 2023
d6971a9
Add a note about alterations and ifdef to polyfill
SeeminglyScience Sep 20, 2023
8c10d8a
Address PR feedback
SeeminglyScience Sep 20, 2023
6019568
Merge branch 'main' into bp-sync
SeeminglyScience Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a note about alterations and ifdef to polyfill
  • Loading branch information
@SeeminglyScience
SeeminglyScience committed Sep 20, 2023
commit d6971a92d8423029c1fd483c94abe1ac42d022c9
5 changes: 5 additions & 0 deletions src/PowerShellEditorServices/Index.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// <auto-generated>
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't 100% know what to do with this and Index. I may have to rip these out and stop using the range syntax for arbitrary legal reasons but I'd like to check out what other MS projects are doing to polyfill.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we chatted about this and it was fine.

// (with alterations)
#if NET5_0_OR_GREATER
[assembly: System.Runtime.CompilerServices.TypeForwardedTo(typeof(System.Index))]
#else

using System.Diagnostics.CodeAnalysis;
using System.Runtime.CompilerServices;
Expand Down Expand Up @@ -152,3 +156,4 @@ public static void ThrowValueArgumentOutOfRange_NeedNonNegNumException()
}
}
}
#endif
5 changes: 5 additions & 0 deletions src/PowerShellEditorServices/Range.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// <auto-generated>
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// (with alterations)
#if NET5_0_OR_GREATER
[assembly: System.Runtime.CompilerServices.TypeForwardedTo(typeof(System.Range))]
#else

global using Range = OmniSharp.Extensions.LanguageServer.Protocol.Models.Range;

Expand Down Expand Up @@ -116,3 +120,4 @@ public static void ThrowArgumentOutOfRangeException(string parameterName)
}
}
}
#endif