Fix piping to native commands for Windows PowerShell #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an unknown reason, we were explicitly overriding `Console.InputEncoding`, which led to a bug where input piped to a native command in Windows PowerShell (where the default encoding is different than our override) would fail. Instead, we just don't override the encodings at all, which lets PSES be closer to the expected experience. The regression test covers this, though to test the failure I had to move that override outside its guard (as it wasn't being set during tests). Also fix building on ARM64 in Windows PowerShell, which doesn't have `$IsWindows`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason, we were explicitly overriding
Console.InputEncoding, which led to a bug where input piped to anative command in Windows PowerShell (where the default encoding is different than our override) would fail. Instead, we just don't override the encodings at all, which lets PSES be closer to the expected experience.
The regression test covers this, though to test the failure I had to move that override outside its guard (as it wasn't being set during tests).
Also fix building on ARM64 in Windows PowerShell, which doesn't have
$IsWindows.Thanks @SeeminglyScience for so quickly figuring out the problem.
Fixes PowerShell/vscode-powershell#4021