Skip to content

Implement temporary workaround for race condition in REPL #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyleejordan wants to merge 4 commits into from
Closed

Implement temporary workaround for race condition in REPL #1774

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eeae6ef
Set execution options consistently
andyleejordan Apr 26, 2022
cd52c3a
Don't cancel on disposal of `CancellationScope`
andyleejordan Apr 26, 2022
c1906ce
Add sleep to REPL loop to temporarily workaround race condition
andyleejordan Apr 26, 2022
c349baf
Fix broken prompt (PSIC) on F5
SeeminglyScience Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix broken prompt (PSIC) on F5
  • Loading branch information
@SeeminglyScience
SeeminglyScience committed Apr 26, 2022
commit c349bafc12818a10a74cd7b9f85e2985d23ed4cb
7 changes: 6 additions & 1 deletion src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation.
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System;
Expand Down Expand Up @@ -739,6 +739,11 @@ private void DoOneRepl(CancellationToken cancellationToken)
StopDebugContext();
}

if (cancellationToken.IsCancellationRequested)
{
return;
Copy link
Member Author

@andyleejordan andyleejordan Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO it did need this?!

}

// When a task must run in the foreground, we cancel out of the idle loop and return to the top level.
// At that point, we would normally run a REPL, but we need to immediately execute the task.
// So we set _skipNextPrompt to do that.
Expand Down