Reset progress messages at end of REPL #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
requested changes
Feb 20, 2022
...owerShellEditorServices/Services/PowerShell/Host/EditorServicesConsolePSHostUserInterface.cs
Outdated
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/reset-progress
branch
2 times, most recently
from
bd602e5 to
f476ef3
Compare
This seems to work. We needed to hold onto processed progress records, and then at the end of the REPL mark each as completed and re-write it (which uses the underlying host and effectively clears it).
andyleejordan
force-pushed
the
andschwa/reset-progress
branch
from
f476ef3 to
dcf7422
Compare
Member
Author
|
This seems to be working now, and it's very close to how it was 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work. We needed to hold onto processed progress records,
and then at the end of the REPL mark each as completed and re-write it
(which uses the underlying host and effectively clears it).
Fixes PowerShell/vscode-powershell#3807