Synchronize PowerShell debugger and DAP server state #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
requested review from
PaulHigin,
JustinGrote and
SeeminglyScience
PaulHigin
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
This looks right to me. Debugger.InBreakpoint property is intended to inform when the runspace associated script debugger has stopped script execution (in breakpoint) and is awaiting debug commands to process, for both local and remote cases. When normal script execution resumes, InBreakpoint becomes false.
This synchronizes the `DebugContext` and LSP debug server state during both edge cases: 1. A REPL happened, the debugger was marked active, and the debugger is now no longer running (it was quit, detached, or continued to the end of the script or function). 2. A user manually cancelled a task, and it was running under the "debugger" (whether or not the PowerShell debugger was active).
|
The newest commit should also fix PowerShell/vscode-powershell#3700. |
andyleejordan
changed the title
stopDebugger during REPL if no longer debugging
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes PowerShell/vscode-powershell#3522 by resurrecting the bug-fix originally implemented in #1570. This allows the user to start a debug session within the integrated console and then have the VS Code debugger stop when the PowerShell debug session stops.
Also resolves #1677 and now fixes PowerShell/vscode-powershell#3700.