Merged
Conversation
This prevents accidental removal (and breakage of the extension) by disallowing `Remove-Variable` from removing `$psEditor`. While it's not expected anyone would do this, glob expressions may include the variable name and when piped to `Remove-Variable` resulted in a user-reported breakage.
andyleejordan
requested review from
JustinGrote,
SeeminglyScience and
daxian-dbw
daxian-dbw
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents accidental removal (and breakage of the extension) by disallowing
Remove-Variablefrom removing$psEditor. While it's not expected anyone would do this, glob expressions may include the variable name and when piped toRemove-Variableresulted in a user-reported breakage.Fixes PowerShell/vscode-powershell#3718.