Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugger's variable population mechanism #1620

Closed
wants to merge 18 commits into from
Closed

Improve debugger's variable population mechanism #1620

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8685daf
Ignore scoping issues with fetching local variables
JustinGrote Nov 5, 2021
d34bf1b
New Serializer for PS Variables to support remoting. BROKEN: ID refer…
JustinGrote Nov 6, 2021
df4d194
Match on both properties and noteproperties
JustinGrote Nov 6, 2021
e9013f3
Make cmdletinvocationexception less specific
JustinGrote Nov 6, 2021
491bff8
Don't serialize local codepaths
JustinGrote Nov 6, 2021
43bbaec
Make serializationDepth constant
JustinGrote Nov 9, 2021
1bf4c79
callStackVarName explicit typing
JustinGrote Nov 9, 2021
b56245d
getPSCallStack explicit string
JustinGrote Nov 9, 2021
eab71ea
Explicit type for isOnRemoteMachine
JustinGrote Nov 9, 2021
bf4ceeb
Explicit Typing for returnSerializedIfOnRemoteMachine
JustinGrote Nov 9, 2021
c624aeb
Address nits
JustinGrote Nov 10, 2021
6e6f73f
Address @andschwa feedback
JustinGrote Nov 10, 2021
2105145
More comprehensive parameter matching
JustinGrote Nov 11, 2021
d8dfbbc
First Pass: Simplify Local and Stack Variable Collection
JustinGrote Nov 12, 2021
8253a9a
Fix fetching script when I wanted to fetch local
JustinGrote Nov 12, 2021
56044e2
Cleanup unnecessary autoVariable assignments
JustinGrote Nov 12, 2021
16b294c
Expose both _ and PSItem
JustinGrote Nov 12, 2021
5ed6fe8
Fix auto variable names
JustinGrote Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make serializationDepth constant 
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
  • Loading branch information
@JustinGrote @SeeminglyScience
JustinGrote and SeeminglyScience committed Nov 9, 2021
commit 43bbaec8401714491211b8f3bc26b767790192de
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ private async Task FetchStackFramesAsync(string scriptNameOverride)
{
PSCommand psCommand = new PSCommand();
// The serialization depth to retrieve variables from remote runspaces.
var serializationDepth = 3;
const int serializationDepth = 3;

// This glorious hack ensures that Get-PSCallStack returns a list of CallStackFrame
// objects (or "deserialized" CallStackFrames) when attached to a runspace in another
Expand Down