Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BinClean dependency from build task #1589

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Remove BinClean dependency from build task #1589

merged 1 commit into from
Oct 18, 2021

Conversation

JustinGrote
Copy link
Collaborator

MSBuild does incremental builds by nature, it is not necessary to do a clean and slows down subsequent builds. "Clean" task should be called if a clean is in fact required.

MSBuild does incremental builds by nature, it is not necessary to do a clean and slows down subsequent builds. "Clean" task should be called if a clean is in fact required.
@andyleejordan andyleejordan changed the title Remove BinClean from Build Task Remove BinClean dependency from build task Oct 18, 2021
@andyleejordan andyleejordan added Area-Build & Release Issue-Enhancement A feature request (enhancement). labels Oct 18, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, totally agree. That's a weird one.

@andyleejordan andyleejordan merged commit ccf1a8d into PowerShell:master Oct 18, 2021
@JustinGrote JustinGrote deleted the justingrote/DisableBinCleanInBuild branch November 1, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants