Remove unnecessary exclusions #1490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is just for intellisense, then it makes sense. But we have to do everything we can to avoid loading those modules generally, since all but the most recent version of PackageManagement have a nasty bug that deadlocks stuff. |
|
I see. I thought it was just an IntelliSense issue but I can see that it's called in 3 other places so I guess the exclusions are still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that IntelliSense no longer imports modules automatically (see #1484 ) we can remove the exclusion list meant to avoid certain modules from being imported unintentionally.