Skip to content

Conversation

@MartinGC94
Copy link
Contributor

Fixes #1176 so IntelliSense gets triggered automatically when writing variables.

@MartinGC94 MartinGC94 requested a review from rjmholt as a code owner March 21, 2021 01:02
@ghost ghost added Area-IntelliSense Issue-Enhancement A feature request (enhancement). labels Mar 21, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not seeing any reason not to take this change, I went ahead and tested locally and I already get completions on $. Then I saw you're using the LSP server via a client in Vim, and so I'm chalking this up to some weirdness with VS Code asking for completions anyway. Thanks for the PR!

@andyleejordan andyleejordan merged commit 9d4e4c2 into PowerShell:master Mar 22, 2021
@MartinGC94
Copy link
Contributor Author

In VS code quickSuggestions are enabled by default which is why $ triggers IntelliSense in VS code out of the box. If you disable them the Powershell specific triggers still start IntelliSense. I don't know if that's working as intended, but it's definitely the behavior I want because quickSuggestions makes IntelliSense a bit too aggressive IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IntelliSense Issue-Enhancement A feature request (enhancement).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trigger characters should contains $ too

2 participants