Skip to content

Use From instead of FromFileSystem #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Use From instead of FromFileSystem #1304

merged 1 commit into from
Jun 5, 2020

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jun 4, 2020

I forgot that these are Uri's - for example: Untitled:Untitled-1

I tested this on Windows and macOS.

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner June 4, 2020 22:05
@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Jun 4, 2020

where is our CI?

@TylerLeonhardt TylerLeonhardt reopened this Jun 5, 2020
@TylerLeonhardt TylerLeonhardt merged commit 2f52bb6 into PowerShell:master Jun 5, 2020
@TylerLeonhardt TylerLeonhardt deleted the use-from-instead-of-fromfilesystem branch June 5, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerLeonhardt @rjmholt