Skip to content

Fix cancellation for completions and add Hover cancellation #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2020
Merged

Fix cancellation for completions and add Hover cancellation #1248

merged 4 commits into from
Mar 31, 2020

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Mar 31, 2020

  • adds some logging for a couple handlers
  • adds cancellation support for the textDocument/hover request
  • adds lock to completionItem/resolve handler which prevents deadlock

@TylerLeonhardt TylerLeonhardt requested a review from rjmholt as a code owner March 31, 2020 22:10
@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Mar 31, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/TextDocument/Handlers/HoverHandler.cs  1

See the complete overview on Codacy

@TylerLeonhardt TylerLeonhardt merged commit 677c7c5 into PowerShell:master Mar 31, 2020
@TylerLeonhardt TylerLeonhardt deleted the fix-cancellation-for-completions branch March 31, 2020 22:46
@TylerLeonhardt TylerLeonhardt mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TylerLeonhardt @rjmholt