Fix startup in AllSigned execution policy #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
Feb 28, 2020
| ExecutionPolicy policyToSet = ExecutionPolicy.Bypass; | ||
| for (int i = policies.Count - 1; i >= 0; i--) | ||
| var currentUserPolicy = (ExecutionPolicy)policies[policies.Count - 2].Members["ExecutionPolicy"].Value; |
There was a problem hiding this comment.
I like this, can we rely on the order to remain consistent though?
There was a problem hiding this comment.
The other alternative is to look for user scope and then to look for machine scope
There was a problem hiding this comment.
But I don't think there's any plan to update anything around execution policy
TylerLeonhardt
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#2504.
We were setting the execution policy before importing PSReadLine. Now we set it afterward.
Not sure what happens with PSSA here.
Ideally we could solve this by linking against those libraries rather than importing them as modules.
EDIT: It also turns out that Execution Policy scope order wasn't what we thought it would be, so we were setting a lower scope first. We now set the CurrentUser scope ahead of the LocalMachine scope.