Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PowerShell/PowerShellEditorServices
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12adcc0
Choose a base ref
...
head repository: PowerShell/PowerShellEditorServices
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2968e35
Choose a head ref
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Jan 24, 2024

  1. Fix up debugger attach handlers 

    First off, the error messages were never actually displayed to the user because
the RpcErrorException constructor takes three arguments. Now the second argument
is always (correctly but annoyingly) null.

Secondly, we do not support attaching to PowerShell Editor Services. It sure
looked like we did (because we had special logic for it) but once attached,
nothing worked. So it was half-baked. Now we throw an error if the user is
trying to do that.

Thirdly, because of that half-baked implementation, the process ID field was
typed as a string (to support "current" as a shortcut) but that caused a mess
here and an error in the VS Code client. Now it's just always an integer. (Same
for the runspace ID.)

Fourthly, a big mess was cleaned up by refactoring using functions, who'd have
thought?

Fifth and finally, superfluous version checking around PowerShell <5.1 was
removed (as those versions are no longer supported whatsoever).
    @andyleejordan
    andyleejordan committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2968e35 View commit details
    Browse the repository at this point in the history
Loading